From d4395c8d1bc401569e4a9d0412d6c2667a61087b Mon Sep 17 00:00:00 2001 From: Bernhard Froehlich Date: Tue, 26 May 2020 19:54:20 +0000 Subject: [PATCH] Fix TestErrors() to not misuse auth bypass --- smtpd_test.go | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/smtpd_test.go b/smtpd_test.go index 24dd90b..8227c4e 100644 --- a/smtpd_test.go +++ b/smtpd_test.go @@ -1188,12 +1188,8 @@ func TestErrors(t *testing.T) { t.Fatalf("AUTH didn't fail: %v", err) } - if err := c.Mail("sender@example.org"); err != nil { - t.Fatalf("MAIL failed: %v", err) - } - if err := c.Mail("sender@example.org"); err == nil { - t.Fatal("Duplicate MAIL didn't fail") + t.Fatalf("MAIL didn't fail") } if err := cmd(c.Text, 502, "STARTTLS"); err != nil { @@ -1228,6 +1224,14 @@ func TestErrors(t *testing.T) { t.Fatalf("AUTH didn't work: %v", err) } + if err := c.Mail("sender@example.org"); err != nil { + t.Fatalf("MAIL failed: %v", err) + } + + if err := c.Mail("sender@example.org"); err == nil { + t.Fatalf("Duplicate MAIL didn't fail") + } + if err := c.Quit(); err != nil { t.Fatalf("Quit failed: %v", err) }